googleapis / googleapis/google-cloud-java

[sdk-platform-java] Add showcase testing for logging on stream cases

Ouverte
#12,395 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
priority: p2 type: process
Langage dominant
Java
Étoiles
2.1k
Forks
1.2k
Merge moyen
1 j 23 h
PR mergées (30 j)
154

Description

Basic logging testing are included in https://github.com/googleapis/sdk-platform-java/pull/3403 for unary calls.
Test cases are missing for server side streaming, client side streaming and bidi-streaming.

We need more test coverage for logging behaviors on other type of calls beside unary calls.

Also, consider refactor showcase test to not depend on a TestAppender, but rather capture log outputs from console. This will allow logging implementation classes like GrpcLoggingInterceptor to be not public.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.