googleapis / googleapis/google-cloud-java

[sdk-platform-java] Add showcase testing for logging on stream cases

Abierto
#12,395 1 comentario 0 reacciones 0 asignados Ver en GitHub
priority: p2 type: process
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

Basic logging testing are included in https://github.com/googleapis/sdk-platform-java/pull/3403 for unary calls.
Test cases are missing for server side streaming, client side streaming and bidi-streaming.

We need more test coverage for logging behaviors on other type of calls beside unary calls.

Also, consider refactor showcase test to not depend on a TestAppender, but rather capture log outputs from console. This will allow logging implementation classes like GrpcLoggingInterceptor to be not public.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.