googleapis / googleapis/google-cloud-java

[sdk-platform-java] showcase upgrade golden files does not run out of box for local dev

オープン
#12,381 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
priority: p3 type: docs
主要言語
Java
スター
2.1k
フォーク
1.2k
平均マージ
1日 23時間
マージ済み PR(30日)
154

説明

When attempting to update golden files according to readme for https://github.com/googleapis/sdk-platform-java/pull/3810:
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/README.md?plain=1#L94

Does not work for my local development out of box:
1. docker build and run. Run docker command without "sudo" is discouraged (go/installdocker#sudoless-docker )
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/scripts/generate_showcase.sh#L56
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/scripts/generate_showcase.sh#L76
3. COPY step in Dockerfile. These two lines gives me "COPY failed: no source files were specified". I was able to get pass errors and successfully update files by removing these two lines. Though I am not familiar with it to determine if they are truely redundant?
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/.cloudbuild/library_generation/library_generation.Dockerfile#L74
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/.cloudbuild/library_generation/library_generation.Dockerfile#L79

my local docker version:
Docker version 20.10.21

Need more context to determine if need fix to these, or updates in readme are sufficient.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。