googleapis / googleapis/google-cloud-java

[sdk-platform-java] showcase upgrade golden files does not run out of box for local dev

Offen
#12,381 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
priority: p3 type: docs
Vorherrschende Sprache
Java
Sterne
2.1k
Forks
1.2k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
154

Beschreibung

When attempting to update golden files according to readme for https://github.com/googleapis/sdk-platform-java/pull/3810:
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/README.md?plain=1#L94

Does not work for my local development out of box:
1. docker build and run. Run docker command without "sudo" is discouraged (go/installdocker#sudoless-docker )
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/scripts/generate_showcase.sh#L56
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/java-showcase/scripts/generate_showcase.sh#L76
3. COPY step in Dockerfile. These two lines gives me "COPY failed: no source files were specified". I was able to get pass errors and successfully update files by removing these two lines. Though I am not familiar with it to determine if they are truely redundant?
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/.cloudbuild/library_generation/library_generation.Dockerfile#L74
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/.cloudbuild/library_generation/library_generation.Dockerfile#L79

my local docker version:
Docker version 20.10.21

Need more context to determine if need fix to these, or updates in readme are sufficient.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.