googleapis / googleapis/google-cloud-java

[java-spanner] SpannerImplTest.testSpannerClosed test needs to detect if Spanner emulator is running

未关闭
#12,238 0 条评论 0 个 reaction 已指派 1 人 已被 @rahul2393 认领 在 GitHub 查看
api: spanner
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
154

描述

Coming here from my PR https://github.com/googleapis/java-spanner/pull/3900 in which I've seen these consistent failures

```shell
Error: com.google.cloud.spanner.SpannerImplTest.testSpannerClosed -- Time elapsed: 0.024 s <<< ERROR!
```

The test fails for both the emulator tests and multiplexed sessions too. We need guards to skip this test if an emulator isn't running or if it isn't, it needs to be running correctly.

Please fix this so that it doesn't cause CI to red and mislead contributors into thinking their code is wrong.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。