googleapis / googleapis/google-cloud-java

[java-spanner] SpannerImplTest.testSpannerClosed test needs to detect if Spanner emulator is running

Abierto
#12,238 0 comentarios 0 reacciones 1 asignado Reclamado por @rahul2393 Ver en GitHub
api: spanner
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

Coming here from my PR https://github.com/googleapis/java-spanner/pull/3900 in which I've seen these consistent failures

```shell
Error: com.google.cloud.spanner.SpannerImplTest.testSpannerClosed -- Time elapsed: 0.024 s <<< ERROR!
```

The test fails for both the emulator tests and multiplexed sessions too. We need guards to skip this test if an emulator isn't running or if it isn't, it needs to be running correctly.

Please fix this so that it doesn't cause CI to red and mislead contributors into thinking their code is wrong.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.