googleapis / googleapis/google-cloud-java

[java-spanner] SpannerImplTest.testSpannerClosed test needs to detect if Spanner emulator is running

Aperta
#12,238 0 commenti 0 reazioni 1 assegnatario Rivendicata da @rahul2393 Vedi su GitHub
api: spanner
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

Coming here from my PR https://github.com/googleapis/java-spanner/pull/3900 in which I've seen these consistent failures

```shell
Error: com.google.cloud.spanner.SpannerImplTest.testSpannerClosed -- Time elapsed: 0.024 s <<< ERROR!
```

The test fails for both the emulator tests and multiplexed sessions too. We need guards to skip this test if an emulator isn't running or if it isn't, it needs to be running correctly.

Please fix this so that it doesn't cause CI to red and mislead contributors into thinking their code is wrong.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.