googleapis / googleapis/google-cloud-java
[java-spanner] SpannerImplTest.testSpannerClosed test needs to detect if Spanner emulator is running
Open
api: spanner
- Dominant language
- Java
- Stars
- 2.1k
- Forks
- 1.2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 154
Description
Coming here from my PR https://github.com/googleapis/java-spanner/pull/3900 in which I've seen these consistent failures
```shell
Error: com.google.cloud.spanner.SpannerImplTest.testSpannerClosed -- Time elapsed: 0.024 s <<< ERROR!
```
The test fails for both the emulator tests and multiplexed sessions too. We need guards to skip this test if an emulator isn't running or if it isn't, it needs to be running correctly.
Please fix this so that it doesn't cause CI to red and mislead contributors into thinking their code is wrong.
Contributor guide
Assessment
This issue has not been assessed yet.