googleapis / googleapis/google-cloud-cpp

The google-cloud-cpp::*-mocks targets are not exported

Open
#5,782 5 comments 0 reactions 1 assignee Claimed by @scotthart View on GitHub
cpp: operator type: feature request
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

These targets are not exported. In practice it does not matter much, because using the library gets you the same `-I` flags, but the applications are missing the `-lgtest*` and `-lgmock*` options.

We need to fix at least the following problems:

- [ ] We need to separate the CMake and pkg-config files for mocks vs. runtime libraries. If we add the mocks to the existing config files then we need to add `find_dependency(gtest)` (and its equivalent in pkg-config lingo) to the config files. It would be very strange to require `googletest` when all you want is to link against the runtime version of the libraries.
- [ ] We need to decide if installing these libraries is optional or not. I think we should **not** make it optional, we have too many knobs already.
- [ ] We need to install these libraries as part of the "development" component (for CMake)
- [ ] We need to add something to the CI builds to verify these libraries are usable once installed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.