googleapis / googleapis/google-cloud-cpp
Reconcile MakeAuthOptions and PopulateAuthOptions
Aperta
type: cleanup
- Lingua principale
- C++
- Stelle
- 659
- Fork
- 462
- Merge medio
- 1g 2h
- PR unite (30g)
- 89
Descrizione
These functions are used in separate places and appear to have similar intent, but while PopulateAuthOptions preserves the existing options its given, MakeAuthOptions discards them. This seems incorrect on the surface, but there may be reasons why it behaves this way. Further investigation is needed to determine if MakeAuthOptions can be changed to preserve the options passed in and/or the two functions could be merged.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.