googleapis / googleapis/google-cloud-cpp

Reconcile MakeAuthOptions and PopulateAuthOptions

Abierto
#15,089 0 comentarios 0 reacciones 0 asignados Ver en GitHub
type: cleanup
Lenguaje dominante
C++
Estrellas
659
Forks
462
Merge medio
1 d 2 h
PR fusionados (30 d)
89

Descripción

These functions are used in separate places and appear to have similar intent, but while PopulateAuthOptions preserves the existing options its given, MakeAuthOptions discards them. This seems incorrect on the surface, but there may be reasons why it behaves this way. Further investigation is needed to determine if MakeAuthOptions can be changed to preserve the options passed in and/or the two functions could be merged.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.