googleapis / googleapis/google-cloud-cpp

Reconcile MakeAuthOptions and PopulateAuthOptions

Ouverte
#15,089 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
type: cleanup
Langage dominant
C++
Étoiles
659
Forks
462
Merge moyen
1 j 2 h
PR mergées (30 j)
89

Description

These functions are used in separate places and appear to have similar intent, but while PopulateAuthOptions preserves the existing options its given, MakeAuthOptions discards them. This seems incorrect on the surface, but there may be reasons why it behaves this way. Further investigation is needed to determine if MakeAuthOptions can be changed to preserve the options passed in and/or the two functions could be merged.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.