googleapis / googleapis/google-cloud-cpp
Make sure we use `google::protobuf::compiler::cpp::FieldName` where needed when emitting code
Aperta
cpp: generator
type: cleanup
- Lingua principale
- C++
- Stelle
- 659
- Fork
- 462
- Merge medio
- 1g 2h
- PR unite (30g)
- 89
Descrizione
In `generator/internal/http_option_utils.cc`, and maybe some other places, we emit code that uses the field name directly without first running it through `google::protobuf::compiler::cpp::FieldName` which handles the case where a field name is a C++ keyword or other disallowed token.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.