googleapis / googleapis/google-cloud-cpp
Make sure we use `google::protobuf::compiler::cpp::FieldName` where needed when emitting code
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 659
- Forks
- 463
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
In generator/internal/http_option_utils.cc, and maybe some other places, we emit code that uses the field name directly without first running it through google::protobuf::compiler::cpp::FieldName which handles the case where a field name is a C++ keyword or other disallowed token.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading generator/internal/http_option_utils.cc and identify each emitted field name that bypasses google::protobuf::compiler::cpp::FieldName. Search nearby generator code for similar direct field-name emission, then verify that all affected generated identifiers handle C++ keywords and other disallowed tokens correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100