googleapis / googleapis/google-cloud-cpp
Make sure we use `google::protobuf::compiler::cpp::FieldName` where needed when emitting code
Open
cpp: generator
type: cleanup
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
In `generator/internal/http_option_utils.cc`, and maybe some other places, we emit code that uses the field name directly without first running it through `google::protobuf::compiler::cpp::FieldName` which handles the case where a field name is a C++ keyword or other disallowed token.
Contributor guide
Assessment
This issue has not been assessed yet.