googleapis / googleapis/google-cloud-cpp

Make sure we use `google::protobuf::compiler::cpp::FieldName` where needed when emitting code

Open
#14,505 0 comments 0 reactions 0 assignees View on GitHub
cpp: generator type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

In `generator/internal/http_option_utils.cc`, and maybe some other places, we emit code that uses the field name directly without first running it through `google::protobuf::compiler::cpp::FieldName` which handles the case where a field name is a C++ keyword or other disallowed token.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.