google / google/GoogleSignIn-iOS
Keep error domain `com.google.GIDSignIn` across the whole library.
未关闭
enhancement
- 主要语言
- Objective-C
- 星标
- 750
- 派生
- 282
- 平均合并
- 2 天 15 小时
- 30 天内合并 PR
- 9
描述
At the moment, we have two error domains in the GSI (`com.google.GIDSignIn` and `com.google.GIDVerify`). Keeping the existing domain (`com.google.GIDSignIn`) will be the domain for all errors from this library while specific error codes will define the error. Though, the issue is avoiding collision across errors since error codes are solely integer backed enum cases and there's a chance integers are backed by the same one. We will revisit this to determine whether we should have two error domains or simplify to one.
Comment issue was brought up: https://github.com/google/GoogleSignIn-iOS/pull/414/files#r1599105257
贡献指南
评估
这个 Issue 还没有评估数据。