google / google/GoogleSignIn-iOS

Keep error domain `com.google.GIDSignIn` across the whole library.

Open
#425 0 comments 0 reactions 1 assignee Claimed by @brnnmrls View on GitHub
enhancement
Dominant language
Objective-C
Stars
750
Forks
282
Avg merge
2d 15h
Merged PRs (30d)
9

Description

At the moment, we have two error domains in the GSI (`com.google.GIDSignIn` and `com.google.GIDVerify`). Keeping the existing domain (`com.google.GIDSignIn`) will be the domain for all errors from this library while specific error codes will define the error. Though, the issue is avoiding collision across errors since error codes are solely integer backed enum cases and there's a chance integers are backed by the same one. We will revisit this to determine whether we should have two error domains or simplify to one.

Comment issue was brought up: https://github.com/google/GoogleSignIn-iOS/pull/414/files#r1599105257

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.