google / google/GoogleSignIn-iOS

Keep error domain `com.google.GIDSignIn` across the whole library.

Aperta
#425 0 commenti 0 reazioni 1 assegnatario Rivendicata da @brnnmrls Vedi su GitHub
enhancement
Lingua principale
Objective-C
Stelle
750
Fork
282
Merge medio
2g 15h
PR unite (30g)
9

Descrizione

At the moment, we have two error domains in the GSI (`com.google.GIDSignIn` and `com.google.GIDVerify`). Keeping the existing domain (`com.google.GIDSignIn`) will be the domain for all errors from this library while specific error codes will define the error. Though, the issue is avoiding collision across errors since error codes are solely integer backed enum cases and there's a chance integers are backed by the same one. We will revisit this to determine whether we should have two error domains or simplify to one.

Comment issue was brought up: https://github.com/google/GoogleSignIn-iOS/pull/414/files#r1599105257

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.