google / google/GoogleSignIn-iOS

Fix unstopped strict mocks in GIDSignInTest.

未关闭
#410 0 条评论 0 个 reaction 已指派 1 人 已被 @brnnmrls 认领 在 GitHub 查看
bug
主要语言
Objective-C
星标
751
派生
282
平均合并
2 天 15 小时
30 天内合并 PR
9

描述

**Description**
Strict mocks in `GIDSignInTest` 'carry forward' in subsequent tests using mocked objects, like `OIDAuthState`. If test receiving error is ran before `GIDSignInTest`, then the test succeeds.

**To Reproduce**
Steps to reproduce the behavior:
1. In `GIDSignInTest.m`, change `OCMClassMock` to `OCMStrictClassMock` for `OIDAuthState` and `GTMAuthSession`.
2. Run all tests under GSI Suite.

**Expected behavior**
Tests in `GIDVerifyAccountDetailTest` should not error due to `OCClassMockObject(OIDAuthState):` since no mocking is done in this file.

**Error message**
[test failure link](https://github.com/google/GoogleSignIn-iOS/actions/runs/8994345490/job/24707662856#step:4:434)
` OCClassMockObject(OIDAuthState): unexpected method invoked: initWithAuthorizationResponse:

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。