google / google/GoogleSignIn-iOS
Fix unstopped strict mocks in GIDSignInTest.
- Lenguaje dominante
- Objective-C
- Estrellas
- 750
- Forks
- 282
- Merge medio
- 2 d 15 h
- PR fusionados (30 d)
- 9
Descripción
**Description**
Strict mocks in `GIDSignInTest` 'carry forward' in subsequent tests using mocked objects, like `OIDAuthState`. If test receiving error is ran before `GIDSignInTest`, then the test succeeds.
**To Reproduce**
Steps to reproduce the behavior:
1. In `GIDSignInTest.m`, change `OCMClassMock` to `OCMStrictClassMock` for `OIDAuthState` and `GTMAuthSession`.
2. Run all tests under GSI Suite.
**Expected behavior**
Tests in `GIDVerifyAccountDetailTest` should not error due to `OCClassMockObject(OIDAuthState):` since no mocking is done in this file.
**Error message**
[test failure link](https://github.com/google/GoogleSignIn-iOS/actions/runs/8994345490/job/24707662856#step:4:434)
` OCClassMockObject(OIDAuthState): unexpected method invoked: initWithAuthorizationResponse:
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.