google / google/GoogleSignIn-iOS

Fix unstopped strict mocks in GIDSignInTest.

Aperta
#410 0 commenti 0 reazioni 1 assegnatario Rivendicata da @brnnmrls Vedi su GitHub
bug
Lingua principale
Objective-C
Stelle
750
Fork
282
Merge medio
2g 15h
PR unite (30g)
9

Descrizione

**Description**
Strict mocks in `GIDSignInTest` 'carry forward' in subsequent tests using mocked objects, like `OIDAuthState`. If test receiving error is ran before `GIDSignInTest`, then the test succeeds.

**To Reproduce**
Steps to reproduce the behavior:
1. In `GIDSignInTest.m`, change `OCMClassMock` to `OCMStrictClassMock` for `OIDAuthState` and `GTMAuthSession`.
2. Run all tests under GSI Suite.

**Expected behavior**
Tests in `GIDVerifyAccountDetailTest` should not error due to `OCClassMockObject(OIDAuthState):` since no mocking is done in this file.

**Error message**
[test failure link](https://github.com/google/GoogleSignIn-iOS/actions/runs/8994345490/job/24707662856#step:4:434)
` OCClassMockObject(OIDAuthState): unexpected method invoked: initWithAuthorizationResponse:

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.