google / google/GoogleSignIn-iOS
Avoid using mock GIDGoogleUser on GIDSignInTest
Aperta
enhancement
triage
- Lingua principale
- Objective-C
- Stelle
- 750
- Fork
- 282
- Merge medio
- 2g 15h
- PR unite (30g)
- 9
Descrizione
Currently the GIDSignInTest using [mock GIDGoogleUser](https://github.com/google/GoogleSignIn-iOS/blob/main/GoogleSignIn/Tests/Unit/GIDSignInTest.m#L1377-L1383) on user sign in process, which makes it hard to verify the value of the signed in user. For improving the test quality, we should create a real GIDGoogleUser object instead of a mock user on GIDSignInTest.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.