google / google/GoogleSignIn-iOS
Avoid using mock GIDGoogleUser on GIDSignInTest
Open
enhancement
triage
- Dominant language
- Objective-C
- Stars
- 750
- Forks
- 282
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 9
Description
Currently the GIDSignInTest using [mock GIDGoogleUser](https://github.com/google/GoogleSignIn-iOS/blob/main/GoogleSignIn/Tests/Unit/GIDSignInTest.m#L1377-L1383) on user sign in process, which makes it hard to verify the value of the signed in user. For improving the test quality, we should create a real GIDGoogleUser object instead of a mock user on GIDSignInTest.
Contributor guide
Assessment
This issue has not been assessed yet.