google / google/GoogleSignIn-iOS
Avoid using mock GIDGoogleUser on GIDSignInTest
Ouverte
enhancement
triage
- Langage dominant
- Objective-C
- Étoiles
- 750
- Forks
- 282
- Merge moyen
- 2 j 15 h
- PR mergées (30 j)
- 9
Description
Currently the GIDSignInTest using [mock GIDGoogleUser](https://github.com/google/GoogleSignIn-iOS/blob/main/GoogleSignIn/Tests/Unit/GIDSignInTest.m#L1377-L1383) on user sign in process, which makes it hard to verify the value of the signed in user. For improving the test quality, we should create a real GIDGoogleUser object instead of a mock user on GIDSignInTest.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.