google-deepmind / google-deepmind/dm_control
`mjcf` parser only supports `include` at root level
Open
- Dominant language
- Python
- Stars
- 4.7k
- Forks
- 764
- PR merge metrics
- No merged PRs in 30d
Description
I think the `mjcf` parser [assumes](https://github.com/google-deepmind/dm_control/blob/main/dm_control/mjcf/parser.py#L199) that `include` elements can only be children of the root element, while, in contrast, MuJoCo allows `include` to live at any depth in the XML tree?
Contributor guide
Research direction
Start in dm_control/mjcf/parser.py at the linked code around line 199 and trace how include elements are handled relative to the root element. Compare that behavior with MuJoCo's support for nested XML includes; done means includes work at any depth without breaking root-level parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100