External styles are being added when no theme is declared in _config.yml
- 主要言語
- Ruby
- スター
- 1.9k
- フォーク
- 360
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
### Before submitting an issue, please be sure to
- [x] Read [the contributing instructions](https://github.com/github/pages-gem/blob/master/docs/CONTRIBUTING.md#contributing-to-the-github-pages-gem)
- [x] Update to the latest Gem version (run `bundle update github-pages`)
### This issue affects
- [x] The site generated by GitHub Pages
- [x] Building sites locally
*The GitHub Pages Gem is intended to help users replicate the GitHub Pages build environment locally. If your issue affects both the hosted version and the version previewed locally, you may be better suited reporting [seeking support in other forums](https://github.com/github/pages-gem/blob/master/docs/SUPPORT.md).*
### What did you do (e.g., steps to reproduce)
1. Clone my repo: `git clone git@github.com:bryanbraun/bryanbraun.github.io.git`
2. Install dependencies: `bundle install`
3. Delete every file ending in `.scss` (for good measure)
4. Run `jekyll build`.
5. See the generated file in `_site/assets/style.css`
### What did you expect to happen?
No CSS files should be generated.
### What happened instead?
A CSS file is generated containing `normalize.css` and other styles from `jekyll-theme-primer`. It looks like my site is falling back to using `jekyll-theme-primer` as its theme, even though I have no themes defined in `_config.yml` (and I don't want to use any external theme).
Possible workaround: If I set `theme: null` it seems like the stylesheet doesn't get added. I'm not sure if this is good to rely on, since it isn't documented anywhere.
### Additional information
This issue [was previously reported in jekyll/jekyll](https://github.com/jekyll/jekyll/issues/7478) but it appears to be an issue with `pages-gem`.
* Link to the live site (if applicable): https://www.bryanbraun.com
* Link to the generated CSS file: https://www.bryanbraun.com/assets/css/style.css
* Link to the source repo (if applicable): https://github.com/bryanbraun/bryanbraun.github.io
コントリビューションガイド
調査の方向性
報告されたリポジトリで `bundle install` と `jekyll build` を実行して問題を再現し、その後 `_config.yml` と生成された `_site/assets/style.css` を調査します。テーマが存在しない場合と `theme: null` の場合を pages-gem がどのように処理するかを追跡します。テーマが宣言されていない場合に外部テーマのスタイルシートが生成されないことを、両方のケースのカバレッジ付きで確認できれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- jekyll, ruby
- 領域
- build-system
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100