External styles are being added when no theme is declared in _config.yml
- Vorherrschende Sprache
- Ruby
- Sterne
- 1.9k
- Forks
- 360
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
### Before submitting an issue, please be sure to
- [x] Read [the contributing instructions](https://github.com/github/pages-gem/blob/master/docs/CONTRIBUTING.md#contributing-to-the-github-pages-gem)
- [x] Update to the latest Gem version (run `bundle update github-pages`)
### This issue affects
- [x] The site generated by GitHub Pages
- [x] Building sites locally
*The GitHub Pages Gem is intended to help users replicate the GitHub Pages build environment locally. If your issue affects both the hosted version and the version previewed locally, you may be better suited reporting [seeking support in other forums](https://github.com/github/pages-gem/blob/master/docs/SUPPORT.md).*
### What did you do (e.g., steps to reproduce)
1. Clone my repo: `git clone git@github.com:bryanbraun/bryanbraun.github.io.git`
2. Install dependencies: `bundle install`
3. Delete every file ending in `.scss` (for good measure)
4. Run `jekyll build`.
5. See the generated file in `_site/assets/style.css`
### What did you expect to happen?
No CSS files should be generated.
### What happened instead?
A CSS file is generated containing `normalize.css` and other styles from `jekyll-theme-primer`. It looks like my site is falling back to using `jekyll-theme-primer` as its theme, even though I have no themes defined in `_config.yml` (and I don't want to use any external theme).
Possible workaround: If I set `theme: null` it seems like the stylesheet doesn't get added. I'm not sure if this is good to rely on, since it isn't documented anywhere.
### Additional information
This issue [was previously reported in jekyll/jekyll](https://github.com/jekyll/jekyll/issues/7478) but it appears to be an issue with `pages-gem`.
* Link to the live site (if applicable): https://www.bryanbraun.com
* Link to the generated CSS file: https://www.bryanbraun.com/assets/css/style.css
* Link to the source repo (if applicable): https://github.com/bryanbraun/bryanbraun.github.io
Beitragsleitfaden
Rechercherichtung
Reproduziere das Problem mit dem gemeldeten Repository, indem du `bundle install` und `jekyll build` ausführst, und überprüfe anschließend `_config.yml` sowie die generierte `_site/assets/style.css`. Verfolge, wie pages-gem mit einem fehlenden Theme im Vergleich zu `theme: null` umgeht; abgeschlossen ist die Aufgabe, wenn kein externes Theme-Stylesheet generiert wird, wenn kein Theme deklariert ist, mit Abdeckung beider Fälle.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- jekyll, ruby
- Bereich
- build-system
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100