Add per-session env overrides for built-in shell tool child processes
- 主要言語
- Java
- スター
- 10.5k
- フォーク
- 1.5k
- 平均マージ
- 1日 11時間
- マージ済み PR(30日)
- 128
説明
Follow up to #1911. The `initScripts` half of that ask shipped through the runtime in github/copilot-agent-runtime#12710, but the per-session `env` part was deferred out of that PR.
Context: https://github.com/microsoft/vscode/issues/323164
`initScripts` covers the Python activation case since the host can materialize a shell-specific activation file and have the runtime source it before each command. An explicit env map is still worth having for hosts that just want to set or unset a few variables without generating script files, and without dealing with per-shell quoting.
Current wire shape:
```ts
export interface ShellOptions {
initProfile?: "none" | "non-interactive";
initScripts?: ShellInitScript[];
processFlags?: string[];
}
```
Add the `env` map from the original proposal:
```ts
export interface ShellOptions {
/** Env applied to built-in shell tool child processes. `null` unsets/removes. */
env?: Record;
}
```
The reason this was deferred is that the update semantics should be pinned down before the wire shape ships:
- Whether `session.rpc.options.update` with `shell.env` replaces the whole overlay or merges per key. Replace seems right: it stays idempotent and a host can revert a variable to the inherited value by omitting it. With merge there is no way to un-touch a variable once set.
- Precedence: overlay applied to the spawned process env first, `initScripts` sourced after, so scripts can override.
- `null` meaning remove-from-env vs revert-to-inherited.
- Whether the overlay persists across resume or the host re-sends it, matching how the rest of `shell` behaves today.
(generated by copilot)
コントリビューションガイド
調査の方向性
Start by tracing the ShellOptions wire shape and session.rpc.options.update handling described in the issue. Review how shell and initScripts behave across updates and resume, then pin down replacement, precedence, null-removal, and persistence semantics; done means the env overlay is represented and applied consistently to built-in shell child processes.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- shell, typescript
- 領域
- api, cli
- issue の種類
- 機能追加
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100