github / github/copilot-sdk

Add per-session env overrides for built-in shell tool child processes

Ouverte
#2,040 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement vs-code
Langage dominant
Java
Étoiles
10.5k
Forks
1.5k
Merge moyen
1 j 11 h
PR mergées (30 j)
128

Description

Follow up to #1911. The `initScripts` half of that ask shipped through the runtime in github/copilot-agent-runtime#12710, but the per-session `env` part was deferred out of that PR.

Context: https://github.com/microsoft/vscode/issues/323164

`initScripts` covers the Python activation case since the host can materialize a shell-specific activation file and have the runtime source it before each command. An explicit env map is still worth having for hosts that just want to set or unset a few variables without generating script files, and without dealing with per-shell quoting.

Current wire shape:

```ts
export interface ShellOptions {
initProfile?: "none" | "non-interactive";
initScripts?: ShellInitScript[];
processFlags?: string[];
}
```

Add the `env` map from the original proposal:

```ts
export interface ShellOptions {
/** Env applied to built-in shell tool child processes. `null` unsets/removes. */
env?: Record;
}
```

The reason this was deferred is that the update semantics should be pinned down before the wire shape ships:

- Whether `session.rpc.options.update` with `shell.env` replaces the whole overlay or merges per key. Replace seems right: it stays idempotent and a host can revert a variable to the inherited value by omitting it. With merge there is no way to un-touch a variable once set.
- Precedence: overlay applied to the spawned process env first, `initScripts` sourced after, so scripts can override.
- `null` meaning remove-from-env vs revert-to-inherited.
- Whether the overlay persists across resume or the host re-sends it, matching how the rest of `shell` behaves today.

(generated by copilot)

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by tracing the ShellOptions wire shape and session.rpc.options.update handling described in the issue. Review how shell and initScripts behave across updates and resume, then pin down replacement, precedence, null-removal, and persistence semantics; done means the env overlay is represented and applied consistently to built-in shell child processes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
shell, typescript
Domaine
api, cli
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.