github / github/copilot-cli

Repository-level enabledPlugins in .github/copilot/settings.json is ignored in non-interactive (copilot -p) mode

Đang mở
#4,507 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

area:non-interactive area:plugins
Ngôn ngữ chính
Shell
Star
11.2k
Fork
1.9k
Merge trung bình
14 giờ 16 phút
Pull request đã merge (30 ngày)
6

Mô tả

Describe the bug

Repository-level enabledPlugins in .github/copilot/settings.json is not applied in non-interactive prompt mode (copilot -p). The same override is applied correctly in interactive mode and by copilot plugins list, so the surfaces disagree.

Concretely: a marketplace plugin set to false at user level and true in a trusted repo's .github/copilot/settings.json is reported as enabled by copilot plugins list for that directory, loads in an interactive session started in that directory, but is silently absent from a copilot -p run in the same directory. There is no warning.

This is the same class of bug as #3345 (.github/hooks/*.json not loaded in -p) and #3088 (copilot plugin marketplace list ignoring repo-level overrides), both of which were fixed.

Affected version

1.0.81-0 (Windows, x86_64)

Steps to reproduce the behavior

Given two marketplace-backed plugins — example-plugin@example-marketplace and other-plugin@other-marketplace — and a trusted folder C:\repos\myrepo (present in trustedFolders in ~/.copilot/config.json):

  1. ~/.copilot/settings.json:

    {
      "enabledPlugins": {
        "other-plugin@other-marketplace": true,
        "example-plugin@example-marketplace": false
      }
    }
    
  2. C:\repos\myrepo\.github\copilot\settings.json:

    {
      "enabledPlugins": {
        "example-plugin@example-marketplace": true
      }
    }
    
  3. From C:\repos\myrepo, run copilot plugins list:

    example-plugin@example-marketplace is shown as enabled (✓) for this directory, and disabled for other directories. Correct.

  4. From C:\repos\myrepo, start an interactive session:

    Startup banner reads Loading: X instructions, 2 plugins, Y skills. The plugin is loaded. Correct.

  5. From C:\repos\myrepo, run copilot -p "Reply with exactly: PONG" with --log-level all:

    Plugin activation [skills]: fingerprint=legacy, plugins=1, loaded=Y
    

    Only other-plugin is loaded. example-plugin does not appear anywhere in the log, and its skills are absent from <available_skills>. This is the bug.

Note that the same -p run does log:

Loading repo hooks in prompt mode (folder is trusted or opt-in set)
Loading workspace MCP sources in prompt mode (folder is trusted or opt-in set)

so repo hooks and workspace MCP sources correctly honour folder trust in prompt mode — only enabledPlugins does not.

Expected behavior

In a trusted folder, copilot -p should apply repository-scoped enabledPlugins from .github/copilot/settings.json, consistent with interactive mode and with copilot plugins list.

At minimum, the two surfaces should agree: copilot plugins list should not report a plugin as enabled for a directory in which copilot -p will silently decline to load it.

Additional context

Root cause (from the 1.0.81-0 bundle). The two modes resolve the plugin set through different code paths:

  • Interactive builds a repository overlay in the UI layer and resolves with repositoryOverlay: { mode: "provided", enabledPlugins, trusted }.

  • Prompt mode computes its plugin list as, in effect:

    const installed = [...getEnabledInstalledPlugins(config.installedPlugins || [], settings.enabledPlugins), ...explicitPlugins];
    

    which calls the native configLoaderGetEnabledInstalledPlugins(installedPlugins, enabledPlugins, pluginDirOnly). That function receives no working directory, no repository overlay, and no trust parameter, so repository-scoped settings cannot reach it.

The session manager's own resolveSessionPluginActivation does use repositoryOverlay: { mode: "load", trust: { mode: "persisted" } }, but in prompt mode the plugin list has already been filtered before it is consulted.

Confirmation. Driving the native resolver (configResolveEffectivePlugins) directly with the two overlay modes, with everything else held constant:

repositoryOverlay resolved plugins in the repo directory
{ mode: "load", trust: { mode: "persisted" } } other-plugin@other-marketplace, example-plugin@example-marketplace
{ mode: "none" } other-plugin@other-marketplace

The observed -p behaviour (plugins=1) matches mode: "none" exactly.

Opt-in env vars. Prompt mode has GITHUB_COPILOT_PROMPT_MODE_REPO_HOOKS, GITHUB_COPILOT_PROMPT_MODE_WORKSPACE_MCP and GITHUB_COPILOT_PROMPT_MODE_EXTENSIONS, but there is no equivalent for plugins/settings, and COPILOT_ALLOW_ALL=true does not cover this path either. So there is no supported way to opt in.

Workaround. Passing the plugin explicitly bypasses the filter, since explicit plugins are appended after it:

copilot -p "..." --plugin-dir "C:\repos\myrepo\skills\example-plugin"

This raises the log line to plugins=2, loaded=Y. It requires hard-coding an absolute path per invocation, so it does not substitute for repo-scoped configuration.

Environment. Windows 11, x86_64, Windows Terminal, PowerShell 7. Reproduced with --log-level all. Not tested on macOS or Linux.

Related: #3345 (fixed, same pattern for repo hooks), #3088 / #3087 (fixed, same interactive-vs-CLI inconsistency), #3742 (repo enabledPlugins override not honoured from nested cwd), #3637 (per-session enabledPlugins overlay).

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Hướng nghiên cứu

Bắt đầu bằng cách tái hiện trường hợp repository đáng tin cậy với copilot -p và --log-level all. Đọc đường đi của chế độ prompt xung quanh getEnabledInstalledPlugins và configLoaderGetEnabledInstalledPlugins, sau đó so sánh với resolveSessionPluginActivation và configResolveEffectivePlugins bằng repository overlay. Hoàn thành khi enabledPlugins của repository được áp dụng trong chế độ prompt và số lượng plugin đã tải cùng các skill khả dụng khớp với chế độ tương tác và copilot plugins list.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
shell
Lĩnh vực
cli, tooling
Loại issue
Lỗi
Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức độ hoạt động
Ít trao đổi
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
55/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.