github / github/copilot-cli

Repository-level enabledPlugins in .github/copilot/settings.json is ignored in non-interactive (copilot -p) mode

Aperta
#4,507 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

area:non-interactive area:plugins
Lingua principale
Shell
Stelle
11.2k
Fork
1.9k
Merge medio
14h 16m
PR unite (30g)
6

Descrizione

Describe the bug

Repository-level enabledPlugins in .github/copilot/settings.json is not applied in non-interactive prompt mode (copilot -p). The same override is applied correctly in interactive mode and by copilot plugins list, so the surfaces disagree.

Concretely: a marketplace plugin set to false at user level and true in a trusted repo's .github/copilot/settings.json is reported as enabled by copilot plugins list for that directory, loads in an interactive session started in that directory, but is silently absent from a copilot -p run in the same directory. There is no warning.

This is the same class of bug as #3345 (.github/hooks/*.json not loaded in -p) and #3088 (copilot plugin marketplace list ignoring repo-level overrides), both of which were fixed.

Affected version

1.0.81-0 (Windows, x86_64)

Steps to reproduce the behavior

Given two marketplace-backed plugins — example-plugin@example-marketplace and other-plugin@other-marketplace — and a trusted folder C:\repos\myrepo (present in trustedFolders in ~/.copilot/config.json):

  1. ~/.copilot/settings.json:

    {
      "enabledPlugins": {
        "other-plugin@other-marketplace": true,
        "example-plugin@example-marketplace": false
      }
    }
    
  2. C:\repos\myrepo\.github\copilot\settings.json:

    {
      "enabledPlugins": {
        "example-plugin@example-marketplace": true
      }
    }
    
  3. From C:\repos\myrepo, run copilot plugins list:

    example-plugin@example-marketplace is shown as enabled (✓) for this directory, and disabled for other directories. Correct.

  4. From C:\repos\myrepo, start an interactive session:

    Startup banner reads Loading: X instructions, 2 plugins, Y skills. The plugin is loaded. Correct.

  5. From C:\repos\myrepo, run copilot -p "Reply with exactly: PONG" with --log-level all:

    Plugin activation [skills]: fingerprint=legacy, plugins=1, loaded=Y
    

    Only other-plugin is loaded. example-plugin does not appear anywhere in the log, and its skills are absent from <available_skills>. This is the bug.

Note that the same -p run does log:

Loading repo hooks in prompt mode (folder is trusted or opt-in set)
Loading workspace MCP sources in prompt mode (folder is trusted or opt-in set)

so repo hooks and workspace MCP sources correctly honour folder trust in prompt mode — only enabledPlugins does not.

Expected behavior

In a trusted folder, copilot -p should apply repository-scoped enabledPlugins from .github/copilot/settings.json, consistent with interactive mode and with copilot plugins list.

At minimum, the two surfaces should agree: copilot plugins list should not report a plugin as enabled for a directory in which copilot -p will silently decline to load it.

Additional context

Root cause (from the 1.0.81-0 bundle). The two modes resolve the plugin set through different code paths:

  • Interactive builds a repository overlay in the UI layer and resolves with repositoryOverlay: { mode: "provided", enabledPlugins, trusted }.

  • Prompt mode computes its plugin list as, in effect:

    const installed = [...getEnabledInstalledPlugins(config.installedPlugins || [], settings.enabledPlugins), ...explicitPlugins];
    

    which calls the native configLoaderGetEnabledInstalledPlugins(installedPlugins, enabledPlugins, pluginDirOnly). That function receives no working directory, no repository overlay, and no trust parameter, so repository-scoped settings cannot reach it.

The session manager's own resolveSessionPluginActivation does use repositoryOverlay: { mode: "load", trust: { mode: "persisted" } }, but in prompt mode the plugin list has already been filtered before it is consulted.

Confirmation. Driving the native resolver (configResolveEffectivePlugins) directly with the two overlay modes, with everything else held constant:

repositoryOverlay resolved plugins in the repo directory
{ mode: "load", trust: { mode: "persisted" } } other-plugin@other-marketplace, example-plugin@example-marketplace
{ mode: "none" } other-plugin@other-marketplace

The observed -p behaviour (plugins=1) matches mode: "none" exactly.

Opt-in env vars. Prompt mode has GITHUB_COPILOT_PROMPT_MODE_REPO_HOOKS, GITHUB_COPILOT_PROMPT_MODE_WORKSPACE_MCP and GITHUB_COPILOT_PROMPT_MODE_EXTENSIONS, but there is no equivalent for plugins/settings, and COPILOT_ALLOW_ALL=true does not cover this path either. So there is no supported way to opt in.

Workaround. Passing the plugin explicitly bypasses the filter, since explicit plugins are appended after it:

copilot -p "..." --plugin-dir "C:\repos\myrepo\skills\example-plugin"

This raises the log line to plugins=2, loaded=Y. It requires hard-coding an absolute path per invocation, so it does not substitute for repo-scoped configuration.

Environment. Windows 11, x86_64, Windows Terminal, PowerShell 7. Reproduced with --log-level all. Not tested on macOS or Linux.

Related: #3345 (fixed, same pattern for repo hooks), #3088 / #3087 (fixed, same interactive-vs-CLI inconsistency), #3742 (repo enabledPlugins override not honoured from nested cwd), #3637 (per-session enabledPlugins overlay).

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia riproducendo il caso del repository attendibile con copilot -p e --log-level all. Leggi il percorso della modalità prompt relativo a getEnabledInstalledPlugins e configLoaderGetEnabledInstalledPlugins, quindi confrontalo con resolveSessionPluginActivation e configResolveEffectivePlugins usando l'overlay del repository. Il lavoro è completato quando gli enabledPlugins del repository vengono applicati in modalità prompt e il numero di plugin caricati e le skill disponibili corrispondono alla modalità interattiva e a copilot plugins list.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
shell
Ambito
cli, tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
55/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.