github / github/copilot-cli

Remote MCP (OAuth/Streamable HTTP): concurrent tool calls during token refresh each spin up a new rmcp service, cancelling in-flight tool calls with "transport closed before the tool responded"

Đang mở
#4,472 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

area:authentication area:mcp
Ngôn ngữ chính
Shell
Star
11.2k
Fork
1.9k
Merge trung bình
14 giờ 16 phút
Pull request đã merge (30 ngày)
6

Mô tả

Summary

When two or more tool calls targeting the same OAuth-protected, Streamable HTTP
MCP server are dispatched concurrently and the access token has expired,
each call independently triggers Refreshing authentication for <server>.
Every refresh creates a new rmcp::service instance, which cancels the
previously-created service. The tool call whose session was cancelled receives
"MCP transport closed before the tool responded", while only the last service
to complete initialization succeeds.

Affected version

GitHub Copilot CLI 1.0.79

Steps to reproduce

  1. Configure a remote Streamable HTTP MCP server with OAuth in
    `~/.copilot/mcp-config.json`.
  2. In a single assistant turn, trigger two or more tool calls to that
    server simultaneously (e.g. by making parallel tool calls that map to the
    same server).
  3. Let the cached access token expire (or clear the tokens file) so a refresh
    is required when the calls fire.
  4. Observe that one or more calls fail with:

    MCP server '': Error: MCP request failed: MCP transport closed
    before the tool responded

CLI logs (anonymised)

The following is extracted from
`~/.copilot/logs/process--.log`:

```
[ERROR] Refreshing authentication for ... ← triggered by call A
[ERROR] Successfully authenticated with
[rust:rmcp::service] task cancelled ← service for call A killed
[rust:rmcp::transport::streamable_http_client] delete session success
[rust:rmcp::service] serve finished {"quit_reason":"Cancelled"}
[rust:rmcp::service] Service initialized as client {...} ← new service, call A session ready

[ERROR] Refreshing authentication for ... ← triggered by call B (concurrent)
[ERROR] Successfully authenticated with
[rust:rmcp::service] task cancelled ← kills the session just created for call A
[rust:rmcp::transport::streamable_http_client] delete session success
[rust:rmcp::service] serve finished {"quit_reason":"Cancelled"}

[WARNING] Failed to refresh persisted MCP tools for ;
continuing with cached tools: Error: MCP server "" is not connected

[rust:rmcp::service] Service initialized as client {...} ← third init, only call B survives
```

Server-side evidence (anonymised)

MCP server logs confirm that the server successfully creates a new transport
session
for the call whose service was cancelled, but never receives a
tool call on that session — because the client-side rmcp service was already
torn down:

```
{"level":"INFO","message":"Created new transport with session ID: ",
"correlation_id":""}

{"level":"INFO","message":"Created new transport with session ID: ",
"correlation_id":""}

{"level":"INFO","message":"Tool called via Streamable HTTP",
"correlation_id":"","tool":"","status":"called"}
{"level":"INFO","message":"Tool completed via Streamable HTTP",
"correlation_id":"","status":"completed","total":N}
```

Session <session-A> is created but never used; only <session-B> receives
tool calls.

Root cause (analysis)

The OAuth refresh path in the Rust MCP client has no mutex / debounce for
concurrent refreshes against the same server. Each concurrent call:

  1. Detects an expired (or missing) access token.
  2. Independently calls `Refreshing authentication for `.
  3. Tears down the current rmcp service (`task cancelled`) and spins up a new
    one with the freshly-obtained token.

Because step 3 is not serialised, the second refresh cancels the session the
first refresh just created. The first call's promise resolves as
"transport closed" because its underlying rmcp service no longer exists.

This is related to but distinct from #3456 (refresh-token rotation/reuse
detection) and #4203 (interactive re-auth instead of silent grant): here the
token refresh itself succeeds silently — the failure is caused by the
uncoordinated service restarts that follow.

Expected behaviour

Concurrent tool calls to the same server should serialise (or coalesce) the
token-refresh + service-restart sequence so that exactly one refresh occurs and
all in-flight calls are queued on the resulting stable session.

Workaround

Dispatch tool calls to the affected server sequentially rather than in
parallel, ensuring each call completes its refresh + session initialisation
before the next one begins.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Hướng nghiên cứu

Bắt đầu từ đường dẫn làm mới OAuth của ứng dụng khách MCP Rust và vòng đời dịch vụ rmcp, sử dụng bản tái hiện các lệnh gọi công cụ đồng thời cùng các nhật ký CLI được liệt kê để theo dõi việc hủy dịch vụ. Xác nhận rằng các lệnh gọi đồng thời đến một máy chủ không còn tạo ra lỗi transport-closed và rằng phiên kết quả vẫn có thể được sử dụng cho tất cả các lệnh gọi.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
rust
Lĩnh vực
api, authentication
Loại issue
Lỗi
Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức độ hoạt động
Ít trao đổi
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
45/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.