Plan mode over-blocks read-only shell commands (keyword false positives)
まだ誰も着手していません。
- 主要言語
- Shell
- スター
- 11.2k
- フォーク
- 1.9k
- 平均マージ
- 14時間 16分
- マージ済み PR(30日)
- 6
説明
Describe the bug
In plan mode, the powershell /shell tool is gated by a heuristic that blocks commands which "may modify the workspace." The classifier appears to match on substrings/tokens rather than actual command semantics, so several provably read-only commands are wrongly blocked, making repository investigation in plan mode harder than it should be.
Confirmed false positives (all read-only, all blocked):
• git merge-base origin/master HEAD — blocked because the string contains merge (matches the mutating verb git merge , but merge-base only reads).
• $mb = git rev-parse HEAD and similar — blocked because of the = assignment (looks like state change; it isn't).
• Select-String / Get-Content — blocked though they only read.
Commands that correctly pass (for contrast):
• git branch --show-current , git status , git --no-pager log/diff/show , git grep , and cd …; git branch … chains.
Impact: Plan mode is meant for read-only investigation (e.g. code review), yet common read-only git/PowerShell reads get blocked, forcing awkward rephrasing.
Suggested fixes:
- Match git verbs as whole tokens ( ^git\s+merge\b ), not the merge substring — unblocks merge-base , merge-tree --write-pack excluded, etc.
- Treat variable assignment of a read-only command as read-only (or ignore = alone as a mutation signal).
- Allow-list known read-only cmdlets: Select-String , Get-Content , Get-ChildItem , Get-Item , Test-Path .
- Optionally: a plan-mode setting to permit an explicit read-only shell allow-list.
Affected version
1.0.71
Steps to reproduce the behavior
Enter plan mode → run git merge-base origin/master HEAD → observe it's blocked as "may modify the workspace."
Expected behavior
In plan mode, commands that are provably read-only should be permitted; only commands that can actually mutate the workspace, git state, or files should be blocked. Specifically:
• git merge-base origin/master HEAD should run — it only computes a commit SHA and writes nothing. Read-only git subcommands ( merge-base , log , diff , show , status , rev-parse , branch --show-current , grep ) should all be allowed, regardless of substrings in their names.
• $mb = git rev-parse HEAD should run — assigning a read-only command's output to a shell variable does not modify the workspace; the mutation check should evaluate the underlying command, not the presence of = .
• Select-String , Get-Content , Get-ChildItem , Test-Path should run — they only read.
• Classification should be based on command semantics / whole-token verb matching, not substring matching, so merge-base is not conflated with git merge .
Actual behavior:
All of the above are blocked with "This shell command may modify the workspace and was blocked. Plan mode does not permit changes to the workspace," even though none of them write anything — forcing the read-only investigation that plan mode is designed for to be rephrased or abandoned.
Additional context
No response
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
Issue に記載されている plan-mode の powershell/shell ツールのコマンド分類器から始め、git merge-base、変数代入、読み取り専用の cmdlet で、列挙された false positive を再現します。コマンドトークンがどのように分類されるかを追跡し、読み取り専用のコマンドが許可される一方で、workspace を変更する可能性のあるコマンドは引き続きブロックされることを確認します。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- git, powershell, shell
- 領域
- cli, tooling
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 静か
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 68/100