github / github/copilot-cli

Plan mode over-blocks read-only shell commands (keyword false positives)

Ouverte
#4,160 3 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
area:permissions area:tools
Langage dominant
Shell
Étoiles
11.2k
Forks
1.9k
Merge moyen
14 h 16 min
PR mergées (30 j)
6

Description

### Describe the bug

In plan mode, the  powershell /shell tool is gated by a heuristic that blocks commands which "may modify the workspace." The classifier appears to match on substrings/tokens rather than actual command semantics, so several provably read-only commands are wrongly blocked, making repository investigation in plan mode harder than it should be.

Confirmed false positives (all read-only, all blocked):

•  git merge-base origin/master HEAD  — blocked because the string contains  merge  (matches the mutating verb  git merge , but  merge-base  only reads).
•  $mb = git rev-parse HEAD  and similar — blocked because of the  =  assignment (looks like state change; it isn't).
•  Select-String  /  Get-Content  — blocked though they only read.

Commands that correctly pass (for contrast):

•  git branch --show-current ,  git status ,  git --no-pager log/diff/show ,  git grep , and  cd …; git branch …  chains.

Impact: Plan mode is meant for read-only investigation (e.g. code review), yet common read-only git/PowerShell reads get blocked, forcing awkward rephrasing.

Suggested fixes:

1. Match git verbs as whole tokens ( ^git\s+merge\b ), not the  merge  substring — unblocks  merge-base ,  merge-tree --write-pack  excluded, etc.
2. Treat variable assignment of a read-only command as read-only (or ignore  =  alone as a mutation signal).
3. Allow-list known read-only cmdlets:  Select-String ,  Get-Content ,  Get-ChildItem ,  Get-Item ,  Test-Path .
4. Optionally: a plan-mode setting to permit an explicit read-only shell allow-list.

### Affected version

1.0.71

### Steps to reproduce the behavior

Enter plan mode → run  git merge-base origin/master HEAD  → observe it's blocked as "may modify the workspace."

### Expected behavior

In plan mode, commands that are provably read-only should be permitted; only commands that can actually mutate the workspace, git state, or files should be blocked. Specifically:

•  git merge-base origin/master HEAD  should run — it only computes a commit SHA and writes nothing. Read-only git subcommands ( merge-base ,  log ,  diff ,  show ,  status ,  rev-parse ,  branch --show-current ,  grep ) should all be allowed, regardless of substrings in their names.
•  $mb = git rev-parse HEAD  should run — assigning a read-only command's output to a shell variable does not modify the workspace; the mutation check should evaluate the underlying command, not the presence of  = .
•  Select-String ,  Get-Content ,  Get-ChildItem ,  Test-Path  should run — they only read.
• Classification should be based on command semantics / whole-token verb matching, not substring matching, so  merge-base  is not conflated with  git merge .

Actual behavior:
All of the above are blocked with "This shell command may modify the workspace and was blocked. Plan mode does not permit changes to the workspace," even though none of them write anything — forcing the read-only investigation that plan mode is designed for to be rephrased or abandoned.

### Additional context

_No response_

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par le classifieur de commandes de l’outil powershell/shell en plan-mode décrit dans l’issue, en reproduisant les faux positifs indiqués avec git merge-base, une affectation de variable et des cmdlets en lecture seule. Suivez la manière dont les tokens de commande sont classés et vérifiez que les commandes en lecture seule sont autorisées, tandis que les commandes qui peuvent modifier le workspace restent bloquées.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
git, powershell, shell
Domaine
cli, tooling
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
68/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.