JS: Atomic group polyfill not detected as a ReDOS mitigation
- 主要言語
- CodeQL
- スター
- 10.1k
- フォーク
- 2.1k
- 平均マージ
- 2日 15時間
- マージ済み PR(30日)
- 141
説明
**Description of the false positive**
You can polyfill atomic groups in JS by using the `/(?=(...))\1//` pattern, but LGTM doesn't seem to understand it and reports a false positive [here](https://lgtm.com/projects/g/compose-regexp/compose-regexp.js/snapshot/e31d432f942019263401085e38558c5661dc7460/files/commonjs/compose-regexp.js?sort=name&dir=ASC&mode=heatmap#xdcee8d483c053100:1).
Here's the culprit:
```JS
var oneEscapeOrCharClassMatcher = /^(?:\\.|\[(?=((?:\\.|.)*?))\1\])$/;
```
There are other similar cases in the project, it is a RegExp composition lib that provides an `atomic(x)` helper that wraps `x` accordingly (and uses such RegExps internally).
Still, to my amusement (and slight consternation), LGTM caught an polynomial ReDOS in my lib... Thanks for the project.
**URL to the alert on the project page on LGTM.com**
https://lgtm.com/projects/g/compose-regexp/compose-regexp.js/snapshot/e31d432f942019263401085e38558c5661dc7460/files/commonjs/compose-regexp.js?sort=name&dir=ASC&mode=heatmap#xdcee8d483c053100:1
コントリビューションガイド
評価
この issue はまだ評価されていません。