github / github/codeql

JS: Atomic group polyfill not detected as a ReDOS mitigation

Ouverte
#9,062 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
false-positive
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

**Description of the false positive**

You can polyfill atomic groups in JS by using the `/(?=(...))\1//` pattern, but LGTM doesn't seem to understand it and reports a false positive [here](https://lgtm.com/projects/g/compose-regexp/compose-regexp.js/snapshot/e31d432f942019263401085e38558c5661dc7460/files/commonjs/compose-regexp.js?sort=name&dir=ASC&mode=heatmap#xdcee8d483c053100:1).

Here's the culprit:

```JS
var oneEscapeOrCharClassMatcher = /^(?:\\.|\[(?=((?:\\.|.)*?))\1\])$/;
```

There are other similar cases in the project, it is a RegExp composition lib that provides an `atomic(x)` helper that wraps `x` accordingly (and uses such RegExps internally).

Still, to my amusement (and slight consternation), LGTM caught an polynomial ReDOS in my lib... Thanks for the project.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/compose-regexp/compose-regexp.js/snapshot/e31d432f942019263401085e38558c5661dc7460/files/commonjs/compose-regexp.js?sort=name&dir=ASC&mode=heatmap#xdcee8d483c053100:1

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.