github / github/codeql

Local variable address stored in non-local memory (False positive)

未關閉
#11,528 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
false-positive not security
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

**Description of the false positive**

I have 6 total false positives of the same category:

* I have structs that are heap allocated (they are NOT stack allocated), and they have methods that assign a global pointer, the value of "this".
* CodeQL has two things wrong here: a) "this" is not a parameter value in C++ and b) the so called parameter value "this" is NOT a stack address. This is clearly a bug in the scanner - had I stored the address of something actually stack allocated from within the function it would clearly be an issue but I'm storing "this" (which definitely is not stack allocated and not even created inside the function).
* All 6 alerts have the same issue; the issue of storing "this" in some global or otherwise surviving pointer. Storing "this" for an object that is heap allocated is definitely not even close to being an issue.

**Code samples or links to source code**

https://github.com/uNetworking/uWebSockets/blob/c4d45fbf3d282bf68a3b44d6dcabad9414f49e84/src/AsyncSocket.h#L123

**URL to the alert on GitHub code scanning (optional)**

https://github.com/uNetworking/uWebSockets/security/code-scanning/101

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。