github / github/codeql

Local variable address stored in non-local memory (False positive)

Aperta
#11,528 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
false-positive not security
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

**Description of the false positive**

I have 6 total false positives of the same category:

* I have structs that are heap allocated (they are NOT stack allocated), and they have methods that assign a global pointer, the value of "this".
* CodeQL has two things wrong here: a) "this" is not a parameter value in C++ and b) the so called parameter value "this" is NOT a stack address. This is clearly a bug in the scanner - had I stored the address of something actually stack allocated from within the function it would clearly be an issue but I'm storing "this" (which definitely is not stack allocated and not even created inside the function).
* All 6 alerts have the same issue; the issue of storing "this" in some global or otherwise surviving pointer. Storing "this" for an object that is heap allocated is definitely not even close to being an issue.

**Code samples or links to source code**

https://github.com/uNetworking/uWebSockets/blob/c4d45fbf3d282bf68a3b44d6dcabad9414f49e84/src/AsyncSocket.h#L123

**URL to the alert on GitHub code scanning (optional)**

https://github.com/uNetworking/uWebSockets/security/code-scanning/101

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.