github / github/codeql

Local variable address stored in non-local memory (False positive)

未关闭
#11,528 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
false-positive not security
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

**Description of the false positive**

I have 6 total false positives of the same category:

* I have structs that are heap allocated (they are NOT stack allocated), and they have methods that assign a global pointer, the value of "this".
* CodeQL has two things wrong here: a) "this" is not a parameter value in C++ and b) the so called parameter value "this" is NOT a stack address. This is clearly a bug in the scanner - had I stored the address of something actually stack allocated from within the function it would clearly be an issue but I'm storing "this" (which definitely is not stack allocated and not even created inside the function).
* All 6 alerts have the same issue; the issue of storing "this" in some global or otherwise surviving pointer. Storing "this" for an object that is heap allocated is definitely not even close to being an issue.

**Code samples or links to source code**

https://github.com/uNetworking/uWebSockets/blob/c4d45fbf3d282bf68a3b44d6dcabad9414f49e84/src/AsyncSocket.h#L123

**URL to the alert on GitHub code scanning (optional)**

https://github.com/uNetworking/uWebSockets/security/code-scanning/101

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。