github / github/accessibility-scanner
Cannot scan sites with self-signed SSL certs
- Ngôn ngữ chính
- TypeScript
- Star
- 369
- Fork
- 40
- Merge trung bình
- 1 ngày 9 giờ
- Pull request đã merge (30 ngày)
- 10
Mô tả
Was giving this tool a little bit of a flex to see how it compares to our Lighthouse workflow, but found that it could not run against our testing environment, since the testing environment uses HTTPS with a self-signed SSL cert.
For context, we set up our testing environment dynamically in GitHub actions, and host it with docker/[DDEV](https://ddev.com/). When that environment is up, we can do Lighthouse, Playwright, and Selenium tests against that environment in GitHub CI to a similar degree that a developer could using their own computer.
When the local environment is set up, URLs that follow this pattern are available: `https://test.ddev.site/my-test-page`. When running this action against that example, we see an error like this:
```
Starting 'find' action
Preparing to scan https://test.ddev.site/my-test-page
node:internal/modules/run_main:107
triggerUncaughtException(
^
page.goto: net::ERR_CERT_AUTHORITY_INVALID at https://test.ddev.site/my-test-page
Call log:
- navigating to "https://test.ddev.site/my-test-page", waiting until "load"
at findForUrl (/home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/dist/findForUrl.js:12:16)
at async Module.default (/home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/dist/index.js:14:32)
at async file:///home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/bootstrap.js:59:5
at async file:///home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/bootstrap.js:31:1 {
name: 'Error'
}
Node.js v24.12.0
```
That error is thrown, and the rest of the job is completely skipped.
Maybe this action needs a new parameter so that the Playwright environment can use the [ignoreHTTPSErrors option](https://playwright.dev/docs/api/class-testoptions#test-options-ignore-https-errors)?
Hướng dẫn đóng góp
Hướng nghiên cứu
Start with the failure path shown in .github/actions/find/dist/findForUrl.js and the find action entry points in .github/actions/find/dist/index.js and bootstrap.js, then trace where the Playwright page or browser context is configured. Add a way to enable the ignoreHTTPSErrors behavior for scans, and verify that the example self-signed HTTPS URL completes instead of aborting the job.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- github-actions, playwright, typescript
- Lĩnh vực
- ci-cd, testing-qa
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 48/100