github / github/accessibility-scanner

Cannot scan sites with self-signed SSL certs

Offen
#150 3 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
TypeScript
Sterne
369
Forks
40
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
10

Beschreibung

Was giving this tool a little bit of a flex to see how it compares to our Lighthouse workflow, but found that it could not run against our testing environment, since the testing environment uses HTTPS with a self-signed SSL cert.

For context, we set up our testing environment dynamically in GitHub actions, and host it with docker/[DDEV](https://ddev.com/). When that environment is up, we can do Lighthouse, Playwright, and Selenium tests against that environment in GitHub CI to a similar degree that a developer could using their own computer.

When the local environment is set up, URLs that follow this pattern are available: `https://test.ddev.site/my-test-page`. When running this action against that example, we see an error like this:

```
Starting 'find' action
Preparing to scan https://test.ddev.site/my-test-page
node:internal/modules/run_main:107
triggerUncaughtException(
^
page.goto: net::ERR_CERT_AUTHORITY_INVALID at https://test.ddev.site/my-test-page
Call log:
- navigating to "https://test.ddev.site/my-test-page", waiting until "load"
at findForUrl (/home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/dist/findForUrl.js:12:16)
at async Module.default (/home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/dist/index.js:14:32)
at async file:///home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/bootstrap.js:59:5
at async file:///home/runner/work/_actions/github/accessibility-scanner/current/.github/actions/find/bootstrap.js:31:1 {
name: 'Error'
}
Node.js v24.12.0
```

That error is thrown, and the rest of the job is completely skipped.

Maybe this action needs a new parameter so that the Playwright environment can use the [ignoreHTTPSErrors option](https://playwright.dev/docs/api/class-testoptions#test-options-ignore-https-errors)?

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the failure path shown in .github/actions/find/dist/findForUrl.js and the find action entry points in .github/actions/find/dist/index.js and bootstrap.js, then trace where the Playwright page or browser context is configured. Add a way to enable the ignoreHTTPSErrors behavior for scans, and verify that the example self-signed HTTPS URL completes instead of aborting the job.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github-actions, playwright, typescript
Bereich
ci-cd, testing-qa
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.