github-tools / github-tools/github-release-notes

Request for support for issues closed with keywords in non-master branch.

オープン
#135 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
897
フォーク
313
PR マージ指標
30日以内にマージされた PR はありません

説明

Reference:
[GitHub: Closing issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)

If you use one of GitHub's keywords for closing an issue in a branch then the issue is marked for closing when the branch is merged with `master`.

*Note: I'm using `git flow`.*
So if i'm working in `hotfix/1.0.6` based on `master`.
And commit with the message `Resolved #12 ....` and push it.
Then the issue is marked for closing when the branch is merge into `master`.
When i finish the branch with `git flow hotfix finish 1.0.6` it tags the last commit with `1.0.6` and merges it into `master`.
When i then run `gren r` I don't get `#12` in my release notes.
In fact since I'm always doing this all my release notes end up on the next tag instead...

Seems to me like this is an issue of `<` instead of `<=`.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start by reproducing the report with `git flow hotfix finish 1.0.6`, a commit containing `Resolved #12`, and `gren r`. Inspect how `gren r` selects issues between the previous and current tags, then verify that an issue closed when the branch merges into `master` appears in the release notes for the correct tag.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript
領域
release
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。