github-tools / github-tools/github-release-notes

Request for support for issues closed with keywords in non-master branch.

未关闭
#135 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
897
派生
313
PR 合并指标
30 天内没有已合并 PR

描述

Reference:
[GitHub: Closing issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)

If you use one of GitHub's keywords for closing an issue in a branch then the issue is marked for closing when the branch is merged with `master`.

*Note: I'm using `git flow`.*
So if i'm working in `hotfix/1.0.6` based on `master`.
And commit with the message `Resolved #12 ....` and push it.
Then the issue is marked for closing when the branch is merge into `master`.
When i finish the branch with `git flow hotfix finish 1.0.6` it tags the last commit with `1.0.6` and merges it into `master`.
When i then run `gren r` I don't get `#12` in my release notes.
In fact since I'm always doing this all my release notes end up on the next tag instead...

Seems to me like this is an issue of `<` instead of `<=`.

贡献指南

打开贡献指南

调研方向

首先使用 `git flow hotfix finish 1.0.6`、包含 `Resolved #12` 的提交以及 `gren r` 重现报告。检查 `gren r` 如何选择前一个标签与当前标签之间的 issue,然后验证在分支合并到 `master` 时关闭的 issue 是否会出现在正确标签的发行说明中。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
release
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。