getsentry / getsentry/sentry-ruby

Custom transaction status code for exceptions

オープン
#2,333 コメント 2 件 リアクション 0 件 担当者 1 名 @sl0thentr0py が担当を希望しています GitHub で見る
Improvement Ruby sentry-rails Spans
主要言語
Ruby
スター
987
フォーク
541
平均マージ
17時間 40分
マージ済み PR(30日)
19

説明

**Describe the idea**

The idea is to allow us to set custom status code for when a exception occurs during a transaction, something like

```ruby
Sentry.init do |config|
config.exception_status_code = ->(exception) do
case exception
when ActiveRecord::RecordNotFound, ActionController::RoutingError
404
else
500
end
end
end
```

**Why do you think it's beneficial to most of the users**

Sentry assumes status code 500 (internal error) for all of the exceptions during transactions. The problem is that in a production environment, by default Rails will raise `ActionController::RoutingError` whenever somebody tries to access a non-existing page, which will result in "internal error" transactions.

This feature allows the user to map different exceptions to different status codes, so they can ignore that without having to change the default Rails behavior.

**Possible implementation**

In the `Sentry::Rack::CaptureExceptions` we can replace the hardcoded 500 status code from the `rescue Exception` with a configurable lambda that returns the desired status code for the specific exception.

Another possibility, is to bake this rule into Sentry (404 for routing errors), but I think that would be a shift in the current behavior which might not be ideal

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。