getsentry / getsentry/sentry-ruby

Custom transaction status code for exceptions

Abierto
#2,333 2 comentarios 0 reacciones 1 asignado Reclamado por @sl0thentr0py Ver en GitHub
Improvement Ruby sentry-rails Spans
Lenguaje dominante
Ruby
Estrellas
987
Forks
541
Merge medio
17 h 40 min
PR fusionados (30 d)
19

Descripción

**Describe the idea**

The idea is to allow us to set custom status code for when a exception occurs during a transaction, something like

```ruby
Sentry.init do |config|
config.exception_status_code = ->(exception) do
case exception
when ActiveRecord::RecordNotFound, ActionController::RoutingError
404
else
500
end
end
end
```

**Why do you think it's beneficial to most of the users**

Sentry assumes status code 500 (internal error) for all of the exceptions during transactions. The problem is that in a production environment, by default Rails will raise `ActionController::RoutingError` whenever somebody tries to access a non-existing page, which will result in "internal error" transactions.

This feature allows the user to map different exceptions to different status codes, so they can ignore that without having to change the default Rails behavior.

**Possible implementation**

In the `Sentry::Rack::CaptureExceptions` we can replace the hardcoded 500 status code from the `rescue Exception` with a configurable lambda that returns the desired status code for the specific exception.

Another possibility, is to bake this rule into Sentry (404 for routing errors), but I think that would be a shift in the current behavior which might not be ideal

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.