getsentry / getsentry/sentry-python

OpenTelemetry symbols marked private to pyright

Aperta
#2,455 12 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Component: Typing Errors Improvement Python Quality Improvement
Lingua principale
Python
Stelle
2.2k
Fork
669
Merge medio
1g 1h
PR unite (30g)
213

Descrizione

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

1.32.0

### Steps to Reproduce

* Use pyright
* Import from opentelemetry package:
```
from sentry_sdk.integrations.opentelemetry import SentryPropagator, SentrySpanProcessor
```
* pyright error:
```
error: "SentryPropagator" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.propagator" instead (reportPrivateImportUsage)
error: "SentrySpanProcessor" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.span_processor" instead (reportPrivateImportUsage)
```

### Expected Result

Import without pyright errors

### Actual Result

Errors as above.

By changing the imports to be more specific pyright would pass but this is not in the [documentation](https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/):
```
from sentry_sdk.integrations.opentelemetry.propagator import SentryPropagator
from sentry_sdk.integrations.opentelemetry.span_processor import SentrySpanProcessor
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.