getsentry / getsentry/sentry-python

OpenTelemetry symbols marked private to pyright

Abierto
#2,455 12 comentarios 0 reacciones 0 asignados Ver en GitHub
Component: Typing Errors Improvement Python Quality Improvement
Lenguaje dominante
Python
Estrellas
2.2k
Forks
669
Merge medio
1 d 1 h
PR fusionados (30 d)
213

Descripción

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

1.32.0

### Steps to Reproduce

* Use pyright
* Import from opentelemetry package:
```
from sentry_sdk.integrations.opentelemetry import SentryPropagator, SentrySpanProcessor
```
* pyright error:
```
error: "SentryPropagator" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.propagator" instead (reportPrivateImportUsage)
error: "SentrySpanProcessor" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.span_processor" instead (reportPrivateImportUsage)
```

### Expected Result

Import without pyright errors

### Actual Result

Errors as above.

By changing the imports to be more specific pyright would pass but this is not in the [documentation](https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/):
```
from sentry_sdk.integrations.opentelemetry.propagator import SentryPropagator
from sentry_sdk.integrations.opentelemetry.span_processor import SentrySpanProcessor
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.