getsentry / getsentry/sentry-python

OpenTelemetry symbols marked private to pyright

Ouverte
#2,455 12 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Component: Typing Errors Improvement Python Quality Improvement
Langage dominant
Python
Étoiles
2.2k
Forks
669
Merge moyen
1 j 1 h
PR mergées (30 j)
213

Description

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

1.32.0

### Steps to Reproduce

* Use pyright
* Import from opentelemetry package:
```
from sentry_sdk.integrations.opentelemetry import SentryPropagator, SentrySpanProcessor
```
* pyright error:
```
error: "SentryPropagator" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.propagator" instead (reportPrivateImportUsage)
error: "SentrySpanProcessor" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.span_processor" instead (reportPrivateImportUsage)
```

### Expected Result

Import without pyright errors

### Actual Result

Errors as above.

By changing the imports to be more specific pyright would pass but this is not in the [documentation](https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/):
```
from sentry_sdk.integrations.opentelemetry.propagator import SentryPropagator
from sentry_sdk.integrations.opentelemetry.span_processor import SentrySpanProcessor
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.