getsentry / getsentry/sentry-python

OpenTelemetry symbols marked private to pyright

Open
#2,455 12 comments 0 reactions 0 assignees View on GitHub
Component: Typing Errors Improvement Python Quality Improvement
Dominant language
Python
Stars
2.2k
Forks
669
Avg merge
1d 1h
Merged PRs (30d)
213

Description

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

1.32.0

### Steps to Reproduce

* Use pyright
* Import from opentelemetry package:
```
from sentry_sdk.integrations.opentelemetry import SentryPropagator, SentrySpanProcessor
```
* pyright error:
```
error: "SentryPropagator" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.propagator" instead (reportPrivateImportUsage)
error: "SentrySpanProcessor" is not exported from module "sentry_sdk.integrations.opentelemetry"
  Import from "sentry_sdk.integrations.opentelemetry.span_processor" instead (reportPrivateImportUsage)
```

### Expected Result

Import without pyright errors

### Actual Result

Errors as above.

By changing the imports to be more specific pyright would pass but this is not in the [documentation](https://docs.sentry.io/platforms/python/performance/instrumentation/opentelemetry/):
```
from sentry_sdk.integrations.opentelemetry.propagator import SentryPropagator
from sentry_sdk.integrations.opentelemetry.span_processor import SentrySpanProcessor
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.