getsentry / getsentry/sentry-javascript
deno: CI runs one Deno version, and a matrix reference is dead
- Ngôn ngữ chính
- TypeScript
- Star
- 8.7k
- Fork
- 1.8k
- Merge trung bình
- 1 ngày 17 giờ
- Pull request đã merge (30 ngày)
- 523
Mô tả
`.github/workflows/build.yml:548`:
```yaml
deno-version: ${{ matrix.deno-version || 'v2.8.3' }}
```
The job has no `strategy: matrix:` block, so `matrix.deno-version` is always empty and the version is always `v2.8.3`. It reads like a matrix that was planned and never wired up.
Related stale note in `dev-packages/deno-integration-tests/suites/orchestrion-mysql/test.ts:19`:
```
// The orchestrion runtime hook only works as a FIRST import inside the entry
// graph in Deno 2.8.0 through 2.8.2.
// TODO: revisit a `--import` or `--preload` approach once Deno 2.8.3 ships.
```
Deno 2.9 is out. The TODO is due.
**Work item.** Either add the matrix the expression expects, or drop the dead `matrix.deno-version ||`. Separately, re-check the `--import` / `--preload` path on 2.9 and update or delete the TODO.
**Prior art ***(related history only)*. No issue. getsentry/sentry-javascript#22790 (merged) set the >= 2.8.3 floor, and getsentry/sentry-javascript#23256 (merged) bumped the `setup-deno` action. Neither touched the dead `matrix.deno-version` expression.
Hướng dẫn đóng góp
Hướng nghiên cứu
Start with .github/workflows/build.yml:548 and dev-packages/deno-integration-tests/suites/orchestrion-mysql/test.ts:19. Run the relevant Deno integration job on Deno 2.9 and check the --import/--preload behavior. Done means the workflow no longer has a dead matrix reference and the stale TODO is updated or removed, with the integration tests passing.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- deno, typescript
- Lĩnh vực
- ci-cd, testing-qa
- Loại issue
- Tái cấu trúc
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Sôi nổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 68/100